Arik Hadas has posted comments on this change. Change subject: core: Move status check methods from VM to VMStatus ......................................................................
Patch Set 4: @Roy - 1. you suggest to rename isGuestUp to isUp? how would you know if it meant the VM or the guest is up? 2. the standard in OOP is that when you have a method such as Object#isEnabled it meant to check whether the Object instance is enabled or not, so if we rename isVmRunning to isRunning for example, the intuition of people who come from OOP background will be that this method checks if the status is running.. -- To view, visit http://gerrit.ovirt.org/10795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82b4f109751773ff2d46407ccea26ea0be2661f5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
