Moti Asayag has posted comments on this change.
Change subject: engine: Assigned resultset to a local var in
StandaloneDataSource:checkConnection()
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/tools/engine-tools-common/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java
Line 151: Statement statement = null;
Line 152: try {
Line 153: statement = connection.createStatement();
Line 154: @SuppressWarnings("unused")
Line 155: ResultSet r = statement.executeQuery("select
null");
i don't agree the suggested code is the correct method of skipping the findbug
error: You solve it by introducing a new warning and force to ignore it...
You'd might better change the executeQuery to execute if you don't care about
the return value of the statement.
Line 156: }
Line 157: finally {
Line 158: if (statement != null) {
Line 159: statement.close();
--
To view, visit http://gerrit.ovirt.org/10959
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5b35703c28560b6aa01497bfef7f09319aebb3c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
