Allon Mureinik has posted comments on this change. Change subject: engine: Assigned resultset to a local var in StandaloneDataSource:checkConnection() ......................................................................
Patch Set 1: I would prefer that you didn't submit this I agree with Moti this isn't the right approach to solve this warning. Moreover, I don't think this method should even exist. The correct approach, IMHO, is just to use JDBC's connection.isValid(), and remove this entire method. -- To view, visit http://gerrit.ovirt.org/10959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5b35703c28560b6aa01497bfef7f09319aebb3c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
