Tomas Jelinek has posted comments on this change.
Change subject: userportal,webadmin: console error message translation ignored
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModelErrorEventListener.java
Line 45: .getMessages()
Line 46: .errConnectingVmUsingRdpMsg(translatedError);
Line 47: }
Line 48:
Line 49: throw new IllegalArgumentException("Message recieved from an
unknown model " + sender.getClass().getName()); //$NON-NLS-1$
No one catches that. The idea behind was that this is a serious issue so we
should fail fast to spot the error quickly. But you are right, returning the
translatedError is a reasonable fallback. Done.
Line 50: }
Line 51:
Line 52: private void consoleModelError(Object sender, String message) {
Line 53: ConfirmationModel model = new ConfirmationModel();
--
To view, visit http://gerrit.ovirt.org/11052
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa0b0d144dcaafffba8911c0cfa41670e179a7c5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
