Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: console error message translation ignored ......................................................................
userportal,webadmin: console error message translation ignored When the SPICE or RDP console returns an error code, it was ignored. Fixed by creating a common ConsoleModelErrorEventListener which listens on the error events and if one occures, shows a popup dialog with the message. It also translates the error code to human readable form. This listener is than used in both userportal and webadmin for both RDP and SPICE This patch also deletes the unused ResourceManager and Assembly classes which where not used anymore and had only empty implementations. Change-Id: Iaa0b0d144dcaafffba8911c0cfa41670e179a7c5 Bug-Url: https://bugzilla.redhat.com/888774 Signed-off-by: Tomas Jelinek <[email protected]> --- A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ConsoleErrorTranslator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModelErrorEventListener.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Assembly.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ResourceManager.java 7 files changed, 112 insertions(+), 131 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa0b0d144dcaafffba8911c0cfa41670e179a7c5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
