Juan Hernandez has posted comments on this change.

Change subject: Removal of a deprecated Public API moudle references
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File frontend/webadmin/modules/gwt-extension/pom.xml
Line 38:       <groupId>org.ovirt.engine.core</groupId>
Line 39:          <artifactId>common</artifactId>
Line 40:          <version>${engine.version}</version>
Line 41:        </dependency>
Line 42:        <dependency>
Spaces instead of tabs?
Line 43:       <groupId>org.ovirt.engine.core</groupId>
Line 44:       <artifactId>utils</artifactId>
Line 45:       <version>${engine.version}</version>
Line 46:     </dependency>


....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 181
Line 182
Line 183
Line 184
Line 185
Removing this line is not enough, as during updates the ovirt-engine-genericapi 
would be orphaned and will block the installation of new versions of other 
ovirt-engine, as it requires the old version of ovirt-engine.

In order to solve this issue you need to include something like this (in 
addition to removing the above line) in the ovirt-engine package:

  # The genericapi package has been deleted, so we need to
  # obsolete it in order to make sure that it is removed when
  # the new version of ovirt-engine is installed:
  Obsoletes: %{name}-genericapi


--
To view, visit http://gerrit.ovirt.org/11262
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I14e79f537e3e45e55b95cf3886c32afb8443ea84
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to