Juan Hernandez has posted comments on this change.
Change subject: Removal of a deprecated Public API moudle references
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Only a minor suggestion about the location of the "Obsoletes" location.
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 190:
Line 191: # genericapi package has been deleted, so we need to
Line 192: # obsolete it in order to make sure that it is removed when
Line 193: # the new version of ovirt-engine is installed:
Line 194: Obsoletes: %{name}-genericapi
I would prefer if you can move this "Obsoletes" after all the "Requires", just
to have all the "Requires" together.
Line 195:
Line 196: # Require other tool packages:
Line 197: Requires: ovirt-iso-uploader
Line 198: Requires: ovirt-image-uploader
--
To view, visit http://gerrit.ovirt.org/11262
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I14e79f537e3e45e55b95cf3886c32afb8443ea84
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
