Sahina Bose has posted comments on this change.
Change subject: gluster: Audit Log Director for gluster
......................................................................
Patch Set 1: (1 inline comment)
Name of class seems to imply it extends AuditLogDirector which is not the case.
It's more like a util/wrapper class. Maybe name could be changed.
Also, can the methods be static. We don't really need an instance of the class
to log messages.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/gluster/GlusterAuditLogDirector.java
Line 68: }
Line 69:
Line 70: @Override
Line 71: public Map<String, String> getCustomValues() {
Line 72: Map<String, String> customValuesMap = new
HashMap<String, String>();
could add to custom values if string array length >= 2. To make sure such
ambiguity does not arise, would it be better that logAuditMessage took an
optional Map<String,String> as parameter?
Line 73: if (customValues != null) {
Line 74: for (String entry[] : customValues) {
Line 75: if (entry != null && entry.length == 2) {
Line 76: customValuesMap.put(entry[0], entry[1]);
--
To view, visit http://gerrit.ovirt.org/11300
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If36dcf305cd6b0ee57cff3bea126f4f6acef740f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
