Michael Kublin has posted comments on this change. Change subject: core:AddVdsSpmIdCommand throw exception when... ......................................................................
Patch Set 2: I would prefer that you didn't submit this Answers to Lior and some other comments, "2. Eli, can you give link to logs or bug#? I don't see how do we have this issue, the PK of the table is the storage pool id + host id, so how can we have pk violation? furthermore, only one host can add this record through transaction beacuse of the lock, can you elaborate when and how it happend? " - not relevant , we can commit without bugs. The race can occurred, especially when there are no common locks. "3. If pk violation does occur now, how this stored procedure will prevent it? when we read from the table during the insert someone might insert record with same value, it's not prevented," - as I can see a locks still there. "4. I prefer to not have this logic on stored procedure, no way to debug it, harder to check for errors." - These is a good point. At any case, I don't see reason to solve these, if race occurred and edit should fail, nothing happened. We just need to provide a good error message. -- To view, visit http://gerrit.ovirt.org/11271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f8aa6b6cb3dfc1508a99c53553afc2e15009b68 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
