Liron Aravot has posted comments on this change. Change subject: engine: AddVdsSpmIdCommand throw exception when... ......................................................................
Patch Set 3: Too bad we didn't start an email thread about it as i made a patch for that too. I think that when executing command transaction, and having it's transaction scope as required - the canDoAction should run also within the same transaction scope. we can see this issue also on commands executed from end methods (that are executed in transaction) causing to the same issue and having to start few transactions each time - so i think that this should be handled regardless...as in those commands we can't do that trick that's done here. Regarding this issue, I like better that the validation will remain in canDoAction method, I prefer the solution of sending all vdss to the AddVdsSpmId at once which also reduce db calls and acquired locks cound - I've made a patch about this here: http://gerrit.ovirt.org/#/c/11412/ if you prefer to go that way, i'll abandon it. -- To view, visit http://gerrit.ovirt.org/11271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f8aa6b6cb3dfc1508a99c53553afc2e15009b68 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
