Mike Kolesnik has posted comments on this change.
Change subject: engine: Replacing search for vms by query
......................................................................
Patch Set 1: (2 inline comments)
Looks good, couple small comments
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java
Line 392:
when(vdsDAO.getAllForVdsGroup(any(Guid.class))).thenReturn(vdsList);
Line 393: }
Line 394:
Line 395: private void allQueriesForVms() {
Line 396: when(vmDao.getAllForVdsGroup(any(Guid.class))).thenReturn(new
ArrayList<VM>());
Why not Collections.emptyList() anymore?
Line 397: }
Line 398:
Line 399: private void vdsGroupHasVds() {
Line 400: List<VDS> vdsList = new ArrayList<VDS>();
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java
Line 212: */
Line 213: List<VM> getAllForNetwork(Guid networkId);
Line 214:
Line 215: /**
Line 216: * Retrieves all VMS that are belongs to provided vds group
A bit weird English, I would suggest:
Retrieves all VMS that belong to the provided vds group
Line 217: * @param vdsGroupId
Line 218: * @return
Line 219: */
Line 220: List<VM> getAllForVdsGroup(Guid vdsGroupId);
--
To view, visit http://gerrit.ovirt.org/11426
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12cee2c66aed35ed357f2ee739232d95fe9fa0c1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
