Allon Mureinik has posted comments on this change.
Change subject: engine: Replacing search for vms by query
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(3 inline comments)
minor comments on grammer
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java
Line 313: assertFalse(result.isEmpty());
Line 314: }
Line 315:
Line 316: /**
Line 317: * Ensure that all VMS which are belongs to VdsGroup return
correct
s/are//
Line 318: */
Line 319: @Test
Line 320: public void testGetAllForVdsGroup() {
Line 321: List<VM> result = dao.getAllForVdsGroup(VDS_GROUP_ID);
....................................................
Commit Message
Line 6:
Line 7: engine: Replacing search for vms by query
Line 8:
Line 9: The following patch is replace a search for vms which are belongs to
some cluster, by
Line 10: query from DB.
"The following patch will replace the search for VMs which belong to some
cluster, by query from DB."
Line 11: The query is much more efficient than search , and easily for
understanding.
Line 12: The patch contains:
Line 13: 1. Introducing new query
Line 14: 2. Replace all searches by new query
Line 7: engine: Replacing search for vms by query
Line 8:
Line 9: The following patch is replace a search for vms which are belongs to
some cluster, by
Line 10: query from DB.
Line 11: The query is much more efficient than search , and easily for
understanding.
s/easily for understanding/easy to understand/
Line 12: The patch contains:
Line 13: 1. Introducing new query
Line 14: 2. Replace all searches by new query
Line 15: 3. Removed class HighAvailableVmsDirector (The following class also
uses a search query, but
--
To view, visit http://gerrit.ovirt.org/11426
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12cee2c66aed35ed357f2ee739232d95fe9fa0c1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
