Omer Frenkel has posted comments on this change.
Change subject: core: start 'prestarted VMs' immediately after update
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolWithVmsCommand.java
Line 57:
Line 58: @Override
Line 59: protected void executeCommand() {
Line 60: super.executeCommand();
Line 61: Backend.getInstance().triggerPoolMonitoringJob();
maybe trigger only if prestarted number changed? (if possible)
Line 62: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
Line 127: case Up:
Line 128: return canAttachPrestartedVmToUser(vm.getId());
Line 129: case WaitForLaunch:
Line 130: case PoweringUp:
Line 131: return vmIsRunningStateless(vm.getId());
please use canAttachPrestartedVmToUser
Line 132: default:
Line 133: return false;
Line 134: }
Line 135: }
--
To view, visit http://gerrit.ovirt.org/11637
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I636f496b241c042962cfec10880fbee00ce2bab4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
