Arik Hadas has posted comments on this change.

Change subject: core: start 'prestarted VMs' immediately after update
......................................................................


Patch Set 2: (3 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
Line 582:     protected QueriesCommandBase<?> createQueryCommand(VdcQueryType 
actionType, VdcQueryParametersBase parameters) {
Line 583:         return CommandsFactory.CreateQueryCommand(actionType, 
parameters);
Line 584:     }
Line 585: 
Line 586:     @Override
Done
Line 587:     public void triggerPoolMonitoringJob() {
Line 588:         
SchedulerUtilQuartzImpl.getInstance().triggerJob(poolMonitoringJobId);
Line 589:     }
Line 590: 


....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/interfaces/BackendInternal.java
Line 56:     public DateTime getStartedAt();
Line 57: 
Line 58:     /**
Line 59:      * Execute the pool monitoring job immediately
Line 60:      */
Done
Line 61:     public void triggerPoolMonitoringJob();
Line 62: 
Line 63:     /**
Line 64:      * Invokes multiple actions of the same action type with different 
parameters under a given execution context which


....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
Line 127:         case Up:
Line 128:             return canAttachPrestartedVmToUser(vm.getId());
Line 129:         case WaitForLaunch:
Line 130:         case PoweringUp:
Line 131:             return vmIsRunningStateless(vm.getId());
Done
Line 132:         default:
Line 133:             return false;
Line 134:         }
Line 135:     }


--
To view, visit http://gerrit.ovirt.org/11637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I636f496b241c042962cfec10880fbee00ce2bab4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to