Allon Mureinik has uploaded a new change for review. Change subject: core: Remove domains member from storage_pool ......................................................................
core: Remove domains member from storage_pool Removed the private member "domains" from the storage_pool class. This member was never updated (in fact, there are no methods to modify it!), and never queried (no such methods exists either), and was only used in the equals(Object) and hashCode() methods. Since its value is always null, it's useless to continue holding it. Change-Id: Iee2b595457d14d8b5c7d6f1697d4dca1236fd1a5 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java 1 file changed, 1 insertion(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/42/11642/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java index deee847..899ae23 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java @@ -1,6 +1,5 @@ package org.ovirt.engine.core.common.businessentities; -import java.util.List; import java.util.Set; import javax.validation.constraints.Pattern; @@ -15,8 +14,7 @@ import org.ovirt.engine.core.compat.Version; public class storage_pool extends IVdcQueryable implements BusinessEntity<Guid> { - - private static final long serialVersionUID = 8455998477522459262L; + private static final long serialVersionUID = -4707023591965221264L; private Guid id = new Guid(); @@ -50,8 +48,6 @@ // TODO this is a hack to get around how the old mappings were done // This will be redone in version 3.0 with proper relationship mapping private Set<VDSGroup> vdsGroups; - - private List<StorageDomainStatic> domains; private Version version; @@ -181,7 +177,6 @@ result = prime * result + ((LVER == null) ? 0 : LVER.hashCode()); result = prime * result + ((compatibilityVersion == null) ? 0 : compatibilityVersion.hashCode()); result = prime * result + ((description == null) ? 0 : description.hashCode()); - result = prime * result + ((domains == null) ? 0 : domains.hashCode()); result = prime * result + ((id == null) ? 0 : id.hashCode()); result = prime * result + masterDomainVersion; result = prime * result + ((name == null) ? 0 : name.hashCode()); @@ -218,11 +213,6 @@ if (other.getcompatibility_version() != null) return false; } else if (!getcompatibility_version().equals(other.getcompatibility_version())) - return false; - if (domains == null) { - if (other.domains != null) - return false; - } else if (!domains.equals(other.domains)) return false; if (id == null) { if (other.id != null) -- To view, visit http://gerrit.ovirt.org/11642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iee2b595457d14d8b5c7d6f1697d4dca1236fd1a5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
