Allon Mureinik has posted comments on this change.
Change subject: core: Remove domains member from storage_pool
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java
Line 13: import org.ovirt.engine.core.compat.NGuid;
Line 14: import org.ovirt.engine.core.compat.Version;
Line 15:
Line 16: public class storage_pool extends IVdcQueryable implements
BusinessEntity<Guid> {
Line 17: private static final long serialVersionUID = -4707023591965221264L;
>> Did you change version id on purpose because you removed a member?
Yes.
>> Is it required to change even though the member was not in use?
"Required" is a big word, but yes, it's considered the best practice.
>> Will it work ok with upgrade?
We do not allow upgrade while tasks are running, so no serialized copies will
exist. In short - yes.
Line 18:
Line 19: private Guid id = new Guid();
Line 20:
Line 21: @ValidName(message = "VALIDATION.DATA_CENTER.NAME.INVALID", groups
= { CreateEntity.class, UpdateEntity.class })
--
To view, visit http://gerrit.ovirt.org/11642
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee2b595457d14d8b5c7d6f1697d4dca1236fd1a5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
