Tal Nisan has posted comments on this change.
Change subject: core: Streamline RemoveExternalEvent canDoAction()
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveExternalEventCommand.java
Line 27: }
Line 28: if (OVIRT.equalsIgnoreCase(event.getOrigin())) {
Line 29: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_EXTERNAL_EVENT_ILLEGAL_ORIGIN);
Line 30: }
Line 31: if (!event.getseverity().equals(AuditLogSeverity.ALERT)) {
Highly unlikely to happen since Engine assumes normal severity in case no log
severity was explicitly defined, but I guess there might be a slight
possibility that the given event severity will be null, since it's not checked
I think it'll be better to use
!AuditLogSeverity.ALERT.equals(event.getseverity())
Line 32: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_EXTERNAL_EVENT_ILLRGAL_OPERATION);
Line 33: }
Line 34:
Line 35: return true;
--
To view, visit http://gerrit.ovirt.org/11641
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d2110e40ad17aea852e1002fe1de5e576dc8248
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
