Allon Mureinik has submitted this change and it was merged. Change subject: core: Streamline RemoveExternalEvent canDoAction() ......................................................................
core: Streamline RemoveExternalEvent canDoAction() Streamlined and cleaned up RemoveExternalEventCommand's canDoAction() method by using the early return pattern and overriding setActionMessageParameters(). A nice side effect of this cleanup was do solve the possible NullPointerExcetion FindBugs was complaining about, as the function would not terminate if the event was null. Change-Id: I3d2110e40ad17aea852e1002fe1de5e576dc8248 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveExternalEventCommand.java 1 file changed, 12 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d2110e40ad17aea852e1002fe1de5e576dc8248 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
