Laszlo Hornyak has posted comments on this change. Change subject: core: auto generate Handler fields from annotations ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java Line 86: @EditableField Line 87: private BootSequence defaultBootSequence = BootSequence.C; Line 88: Line 89: @EditableOnVmStatusField Line 90: private int niceLevel; I believe it is correct, fields with @EditableOnVmStatusField are added to a different list than @EditableField, see original VmHandler Line 91: Line 92: @EditableField Line 93: private boolean autoSuspend; Line 94: -- To view, visit http://gerrit.ovirt.org/11916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8441f030c161c99c630a945b8b0228114665aa17 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
