Omer Frenkel has posted comments on this change. Change subject: core: auto generate Handler fields from annotations ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java Line 89: @EditableOnVmStatusField Line 90: private int niceLevel; Line 91: Line 92: @EditableField Line 93: private boolean autoSuspend; you know its not, you deleted the code using it, please send a patch to clean it up :) (db also) Line 94: Line 95: @EditableField Line 96: private int priority; Line 97: -- To view, visit http://gerrit.ovirt.org/11916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8441f030c161c99c630a945b8b0228114665aa17 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
