Lior Vernia has uploaded a new change for review.

Change subject: webadmin: Removed sorting from Setup Networks popup
......................................................................

webadmin: Removed sorting from Setup Networks popup

The sorting was done purely lexicographically, which could be somewhat
wrong, and would actually override the proper sorting done now in the
host interfaces query.

Change-Id: I4ef5688558e827b91d0741147975b683c4af2909
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=883269
Signed-off-by: Lior Vernia <[email protected]>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/99/11999/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java
index 0a73ad8..c3c0cd6 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java
@@ -159,7 +159,6 @@
 
     private void updateNics(List<NetworkInterfaceModel> nics) {
         nicList.clear();
-        Collections.sort(nics);
         List<NetworkGroup> groups = new ArrayList<NetworkGroup>();
         for (NetworkInterfaceModel nic : nics) {
             groups.add(new NetworkGroup(nic, style));


--
To view, visit http://gerrit.ovirt.org/11999
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ef5688558e827b91d0741147975b683c4af2909
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to