liron aravot has posted comments on this change.
Change subject: code: Replace slf4j-nop with slf4j-log4j
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File backend/manager/modules/dal/pom.xml
Line 67: <artifactId>spring-test</artifactId>
Line 68: </dependency>
Line 69: <dependency>
Line 70: <groupId>org.slf4j</groupId>
Line 71: <artifactId>slf4j-log4j12</artifactId>
can you elaborate on that change?
slf4j-nop discards all logging..not that i have problem with logging..but
wasn't that done intentionally for some reason?
Line 72: <version>${slf4j-jdk14.version}</version>
Line 73: <scope>test</scope>
Line 74: </dependency>
Line 75: <dependency>
....................................................
File backend/manager/modules/utils/pom.xml
Line 95: </dependency>
Line 96:
Line 97: <dependency>
Line 98: <groupId>org.slf4j</groupId>
Line 99: <artifactId>slf4j-log4j12</artifactId>
same as previous comment..
Line 100: <version>${slf4j-jdk14.version}</version>
Line 101: <scope>test</scope>
Line 102: </dependency>
Line 103:
--
To view, visit http://gerrit.ovirt.org/12082
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ce598b4188942914f5638e52f9564bda42463af
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
