Allon Mureinik has posted comments on this change. Change subject: code: Replace slf4j-nop with slf4j-log4j ......................................................................
Patch Set 1: @Liron - The idea is to be able to log effectively, as you mentioned. There are two considerations here: 1. slf4j-log4j allows you to actually log something (as opposed to just suppressing). You can always suppress the logging with log4j configuration if you need to. 2. To align with BLL's logging scheme, which indeed uses slf4j-log4j. @Asaf - as noted in my answer to Liron, the BLL module /already/ (i.e., before this patch), uses slf4j-log4j. The intent is to align all the modules, so we'll have as little useless jars as possible. AFAIK, the slf4j package in fedora includes all slf4j jars (-api, -log4j, -nop, etc.) -- To view, visit http://gerrit.ovirt.org/12082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ce598b4188942914f5638e52f9564bda42463af Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: liron aravot <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
