Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Refactoring in unassign network from cluster command ......................................................................
engine: Refactoring in unassign network from cluster command Refactored some code in DetachNetworkToVdsGroupCommand to reuse code from NetworkValidator. As part of the refactoring added to the error message the list of VMs/templates using the network, if it was used, simply by using the internal implementation of the validation in NetworkValidator. Change-Id: I127615d9144084ad093ac1d20841979be8163a12 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=746912 Signed-off-by: Lior Vernia <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java 1 file changed, 38 insertions(+), 67 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/10683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I127615d9144084ad093ac1d20841979be8163a12 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Muli Salem <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
