Allon Mureinik has uploaded a new change for review. Change subject: core: Clean up Version.OpEquality ......................................................................
core: Clean up Version.OpEquality Proper handling of boolean values in OpEquality. Change-Id: Ib09be089763a101ff77e2bbf32970af827cd38df Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/60/12260/1 diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java index 65230c5..279889e 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java @@ -150,10 +150,10 @@ } public static boolean OpEquality(Version v1, Version v2) { - if (v1 == null) - return (v2 == null) ? true : false; - else - return v1.equals(v2); + if (v1 == null) { + return (v2 == null); + } + return v1.equals(v2); } public static boolean OpInequality(Version v1, Version v2) { -- To view, visit http://gerrit.ovirt.org/12260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib09be089763a101ff77e2bbf32970af827cd38df Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
