Allon Mureinik has posted comments on this change.
Change subject: core: Clean up Version.OpEquality
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
Line 149:
Line 150: }
Line 151:
Line 152: public static boolean OpEquality(Version v1, Version v2) {
Line 153: if (v1 == null) {
I really, really, hate ternary operations.
I won't nack it if someone uses it, but I can't bring myself to write one.
Line 154: return (v2 == null);
Line 155: }
Line 156: return v1.equals(v2);
Line 157: }
--
To view, visit http://gerrit.ovirt.org/12260
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib09be089763a101ff77e2bbf32970af827cd38df
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
