Maor Lipchuk has uploaded a new change for review. Change subject: core: Event should log disk alias instead UNKNOWN. ......................................................................
core: Event should log disk alias instead UNKNOWN. When removing a disk, we should indicate the disk name instead <UNKNOWN> string. The <UNKNOWN> is presented since engine tries to get the disk alias after the disk was already deleted. The fix is to initialize the disk parameter before the deletion. Change-Id: Id111a067819cd881ee6fd22b588562028087fee8 Signed-off-by: Maor Lipchuk <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/62/12262/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java index 6aebde1..ed60890 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java @@ -327,6 +327,7 @@ for (VM vm : listVms) { getVmStaticDAO().incrementDbGeneration(vm.getId()); } + disk = getDiskDao().get((Guid) getParameters().getEntityId()); Backend.getInstance().EndAction(VdcActionType.RemoveImage, getParameters().getImagesParameters().get(0)); setSucceeded(true); } -- To view, visit http://gerrit.ovirt.org/12262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id111a067819cd881ee6fd22b588562028087fee8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
