Liron Aravot has posted comments on this change.
Change subject: core: Event should log disk alias instead UNKNOWN.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
Line 326: List<VM> listVms = getVmsForDiskId();
Line 327: for (VM vm : listVms) {
Line 328: getVmStaticDAO().incrementDbGeneration(vm.getId());
Line 329: }
Line 330: disk = getDiskDao().get((Guid) getParameters().getEntityId());
I'd consider make use of getDisk() or have that logic exported somewhere as
it contains the same line .
Line 331: Backend.getInstance().EndAction(VdcActionType.RemoveImage,
getParameters().getImagesParameters().get(0));
Line 332: setSucceeded(true);
Line 333: }
Line 334:
--
To view, visit http://gerrit.ovirt.org/12262
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id111a067819cd881ee6fd22b588562028087fee8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
