Allon Mureinik has uploaded a new change for review. Change subject: core: Remove the Helper class ......................................................................
core: Remove the Helper class org.ovirt.engine.core.utils.Helper had only one method, ToList, which was, in fact, just creating a new ArrayList around a given iterable. This patch removes this useless class, and just calls ArrayList's constructor instead. Change-Id: I2563766d08aeece478ac7659103f26f19b90deb3 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Helper.java 2 files changed, 3 insertions(+), 13 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/22/12422/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java index 3f4c783..6027a17 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java @@ -1,5 +1,6 @@ package org.ovirt.engine.core.bll; +import java.util.ArrayList; import java.util.List; import java.util.Map; @@ -50,7 +51,6 @@ import org.ovirt.engine.core.dal.dbbroker.DbFacade; import org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector; import org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogableBase; -import org.ovirt.engine.core.utils.Helper; import org.ovirt.engine.core.utils.ThreadUtils; import org.ovirt.engine.core.utils.Ticketing; import org.ovirt.engine.core.utils.linq.Function; @@ -148,7 +148,8 @@ // is on List<VmStatic> vmsToMigrate = DbFacade.getInstance().getVmStaticDao().getAllWithFailbackByVds(vds.getId()); - java.util.ArrayList<VdcActionParametersBase> vmToServerParametersList = Helper.ToList(LinqUtils + ArrayList<VdcActionParametersBase> vmToServerParametersList = + new ArrayList<VdcActionParametersBase>(LinqUtils .foreach(vmsToMigrate, new Function<VmStatic, VdcActionParametersBase>() { @Override public VdcActionParametersBase eval(VmStatic vm) { diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Helper.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Helper.java deleted file mode 100644 index e7a5354..0000000 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Helper.java +++ /dev/null @@ -1,11 +0,0 @@ -package org.ovirt.engine.core.utils; - -public final class Helper { - public static <T> java.util.ArrayList<T> ToList(Iterable<T> inList) { - java.util.ArrayList<T> outList = new java.util.ArrayList<T>(); - for (T item : inList) { - outList.add(item); - } - return outList; - } -} -- To view, visit http://gerrit.ovirt.org/12422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2563766d08aeece478ac7659103f26f19b90deb3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
