Liron Aravot has posted comments on this change.
Change subject: core : AddVmFromSnapshot - use device information from snapshot.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 259: * @param dstId
Line 260: * @param disks
Line 261: * The disks which were saved for the destination VM.
Line 262: */
Line 263: public static void copyVmDevices(Guid srcId, Guid dstId,
List<DiskImage> disks, List<VmNetworkInterface> ifaces) {
note: this code was here before, i've exported the rest of the method so it
could be called with the snapshot configuration rather then the active vm
configuration.
Line 264: VM vm = DbFacade.getInstance().getVmDao().get(dstId);
Line 265: VmBase vmBase = (vm != null) ? vm.getStaticData() : null;
Line 266: boolean isVm = (vmBase != null);
Line 267: if (!isVm) {
--
To view, visit http://gerrit.ovirt.org/12452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0611bbbef00fd2c2390ead5f3110e56dcaacd579
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
