Liron Aravot has posted comments on this change.
Change subject: core : AddVmFromSnapshot - use device information from snapshot.
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
Line 223: }
Line 224:
Line 225: @Override
Line 226: protected void copyVmDevices() {
Line 227: ArrayList<VmDevice> devices = new
ArrayList<VmDevice>(vmFromConfiguration.getVmUnamagedDeviceList());
changed to List<VmDevice>
Line 228:
devices.addAll(vmFromConfiguration.getManagedVmDeviceMap().values());
Line 229: VmDeviceUtils.copyVmDevices(getVmIdFromSnapshot(), getVmId(),
vmFromConfiguration, vmFromConfiguration.getStaticData(), true, devices,
newDiskImages, _vmInterfaces);
Line 230: }
Line 231:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 156: updateUSBSlots(entity, entity);
Line 157: }
Line 158: }
Line 159:
Line 160: public static void copyVmDevices(Guid srcId, Guid dstId, VM vm,
VmBase vmBase, boolean isVm, List<VmDevice> devices, List<DiskImage> disks,
List<VmNetworkInterface> ifaces) {
added java doc comment - will consider the test.
Line 161: Guid id;
Line 162: int diskCount = 0;
Line 163: int ifaceCount = 0;
Line 164: String isoPath=vmBase.getIsoPath();
--
To view, visit http://gerrit.ovirt.org/12452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0611bbbef00fd2c2390ead5f3110e56dcaacd579
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
