Itamar Heim has posted comments on this change. Change subject: engine: cleaning-up PowerClient ......................................................................
Patch Set 2: I would prefer that you didn't submit this (7 inline comments) 2 config keys which are not power client specific in spite name, one method not deleted correctly in RunVmCommandBase. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ApproveVdsCommand.java Line 50 Line 51 Line 52 Line 53 Line 54 this one may still be relevant actually for auto approving ovirt-nodes registrating. need to check if this flow is still working after all the otopi changes though. iirc, flow isn't limited to power clients, in spite of config name .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java Line 212 Line 213 Line 214 Line 215 Line 216 same comment - auto approval is not power client speciifc and is applicable for ovirt node as well (though needs to be tested to see if working) Line 507 Line 508 Line 509 Line 510 Line 511 same - config key name is misleading - relevant for ovirt-node as well. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java Line 182 Line 183 Line 184 Line 185 Line 186 -1... this method is only for power client. it's if ... != VDSType.PowerClient. return; so you simply need to delete the entire method... .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSType.java Line 3 Line 4 Line 5 Line 6 Line 7 in theory, you'd need to check during upgrade this doesn't exist, but i think safe enough to assume it isn't... .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java Line 489 Line 490 Line 491 Line 492 Line 493 relevant to ovirt-node as well Line 508 Line 509 Line 510 Line 511 Line 512 relevant to ovirt-node as well. -- To view, visit http://gerrit.ovirt.org/8876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b61e6098bc1733bb39ce51cf2b25559a376c876 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Noam Slomianko <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
