Gilad Chaplik has posted comments on this change. Change subject: engine: cleaning-up PowerClient ......................................................................
Patch Set 2: (6 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ApproveVdsCommand.java Line 50 Line 51 Line 52 Line 53 Line 54 will rename to ConfigValues.AutoInstallCertificateOnApprove. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java Line 507 Line 508 Line 509 Line 510 Line 511 Done. will test it later on. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java Line 182 Line 183 Line 184 Line 185 Line 186 PowerClientSpiceDynamicCompressionManagement is true in ConfigValues and false in DB .. that's what got me confused. Done. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSType.java Line 3 Line 4 Line 5 Line 6 Line 7 np, if you still want it, which type you want it to be changed (0/2)? .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java Line 489 Line 490 Line 491 Line 492 Line 493 renamed (removed PowerClient prefix) Line 508 Line 509 Line 510 Line 511 Line 512 renamed (removed PowerClient prefix) -- To view, visit http://gerrit.ovirt.org/8876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b61e6098bc1733bb39ce51cf2b25559a376c876 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Noam Slomianko <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
