Alon Bar-Lev has posted comments on this change. Change subject: packaging: Added checking DB state before upgrade ......................................................................
Patch Set 3: (1 inline comment) See basedefs regarding taskcleaner. Behavior of installation has nothing to do with legacy vs otopi, we should do this properly now, as these two setups should be able to live side-by-side. I don't understand why proper database files, managed by dba cannot be distributed (if actually needed) by the setup... .................................................... File packaging/fedora/setup/basedefs.py Line 162: EXEC_SETSEBOOL="/usr/sbin/setsebool" Line 163: EXEC_SEMANAGE="/usr/sbin/semanage" Line 164: EXEC_KEYTOOL="/usr/bin/keytool" Line 165: EXEC_TASK_CLEANER = "%s/ovirt-engine/scripts/taskcleaner/taskcleaner.sh" % DIR_USR_SHARE Line 166: EXEC_FKVALIDATOR = "%s/ovirt-engine/scripts/taskcleaner/fkvalidator.sh" % DIR_USR_SHARE The fact that this is in taskcleaner is a mistake? Line 167: Line 168: CONST_BASE_MAC_ADDR="00:1A:4A" Line 169: CONST_DEFAULT_MAC_RANGE="00:1a:4a:16:84:02-00:1a:4a:16:84:fd" Line 170: CONST_MINIMUM_SPACE_ISODOMAIN=350 -- To view, visit http://gerrit.ovirt.org/12512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief0e65231bb42b569734cdd2fa6491b645491f98 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
