Vered Volansky has posted comments on this change. Change subject: core:VM pool snapshot should not be stateless. ......................................................................
Patch Set 3: I would prefer that you didn't submit this (6 inline comments) All my comments refer to the commit message, but I really don't think it should be submitted as it is. .................................................... Commit Message Line 5: CommitDate: 2013-02-28 20:22:36 +0200 Line 6: Line 7: core:VM pool snapshot should not be stateless. Line 8: Line 9: After upgrading from version 3.0, the snapshots of VM's which are s/VM's/VMs, s/which/that Line 10: part of a pool are marked as stateless although they are don't. Line 11: Line 12: There is not need to save the image_vm_pool_map data in the Line 13: stateless_vm_image_map since snapshots which are created for stateless Line 6: Line 7: core:VM pool snapshot should not be stateless. Line 8: Line 9: After upgrading from version 3.0, the snapshots of VM's which are Line 10: part of a pool are marked as stateless although they are don't. /s/are don't/aren't Line 11: Line 12: There is not need to save the image_vm_pool_map data in the Line 13: stateless_vm_image_map since snapshots which are created for stateless Line 14: VM should already be saved in this table already. Line 8: Line 9: After upgrading from version 3.0, the snapshots of VM's which are Line 10: part of a pool are marked as stateless although they are don't. Line 11: Line 12: There is not need to save the image_vm_pool_map data in the /s/not/no Line 13: stateless_vm_image_map since snapshots which are created for stateless Line 14: VM should already be saved in this table already. Line 15: Line 16: Also, added a script, which should fix the already upgraded VMs, witch Line 9: After upgrading from version 3.0, the snapshots of VM's which are Line 10: part of a pool are marked as stateless although they are don't. Line 11: Line 12: There is not need to save the image_vm_pool_map data in the Line 13: stateless_vm_image_map since snapshots which are created for stateless s/which/that, either 'a stateless VM' or 'stateless VMs' Line 14: VM should already be saved in this table already. Line 15: Line 16: Also, added a script, which should fix the already upgraded VMs, witch Line 17: contains the stateless snapshots. Line 10: part of a pool are marked as stateless although they are don't. Line 11: Line 12: There is not need to save the image_vm_pool_map data in the Line 13: stateless_vm_image_map since snapshots which are created for stateless Line 14: VM should already be saved in this table already. remove last already Line 15: Line 16: Also, added a script, which should fix the already upgraded VMs, witch Line 17: contains the stateless snapshots. Line 18: Line 12: There is not need to save the image_vm_pool_map data in the Line 13: stateless_vm_image_map since snapshots which are created for stateless Line 14: VM should already be saved in this table already. Line 15: Line 16: Also, added a script, which should fix the already upgraded VMs, witch /s/witch/which ? Line 17: contains the stateless snapshots. Line 18: Line 19: Change-Id: I9aaccd3c624c2ab6bcc6f4a0510b26d37f2c1eee Line 20: Bug-Url: https://bugzilla.redhat.com/882621 -- To view, visit http://gerrit.ovirt.org/9794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aaccd3c624c2ab6bcc6f4a0510b26d37f2c1eee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
