Eli Mesika has posted comments on this change. Change subject: core:VM pool snapshot should not be stateless. ......................................................................
Patch Set 5: Well I totally agree with Allon. You need to issue only the fix and not touch existing upgrade Keep in mind that 1) for upgrades, the old script was already installed so it will not be run again and the new script is supposed to fix the problem 2) for clean install, the old script is harmless since no snapshots are defined in the system What we will do is squash each unsupported upgrade script to the create* scripts For example , in 3.3 , all 3.0 scripts will be squashed to the create* scripts, so , in the long run this duplication will disappear -- To view, visit http://gerrit.ovirt.org/9794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aaccd3c624c2ab6bcc6f4a0510b26d37f2c1eee Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
