Yair Zaslavsky has posted comments on this change.
Change subject: engine : Refactoring Async tasks code
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TasksUtil.java
Line 30: import org.ovirt.engine.core.utils.transaction.TransactionSupport;
Line 31:
Line 32: /**
Line 33: *
Line 34: * @author rnori
No author please :)
Line 35: */
Line 36: public class TasksUtil {
Line 37: public static final TasksUtil instance = new TasksUtil();
Line 38: public static final Log log =
LogFactory.getLog(instance.getClass());
Line 32: /**
Line 33: *
Line 34: * @author rnori
Line 35: */
Line 36: public class TasksUtil {
Hi, can you please elaborate more at commit msg why you introduced this task?
Line 37: public static final TasksUtil instance = new TasksUtil();
Line 38: public static final Log log =
LogFactory.getLog(instance.getClass());
Line 39: /**
Line 40: * Use this method in order to create task in the AsyncTaskManager
in a safe way. If you use this method within a
--
To view, visit http://gerrit.ovirt.org/12561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3839ed09825f1e0db914f55f5ee358b6b3c0449
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
