Yair Zaslavsky has posted comments on this change. Change subject: engine : Refactoring Async tasks code ......................................................................
Patch Set 2: Answers for Yaniv - " If you have singleton for creating tasks do we still need TaskHandlerCommand? I don't see the reason for this interface.. Seems like we have a lot of mess around the tasks. How can we have specific implementation for SPMAsyncTasks? Don't we have only SPM async tasks? what other AsyncTasks can we have?" TaskHandlerCommand is a part of the serial command execution mechanism that Live Storage Migration uses. " A class diagram or short explanation of how and why the implementation is right now as it is might help to proceed and decide about the separation of the code." You are correct in general, but bare in mind the development was evolutional , and in some cases "ad hoc" code was added to solve various scenarios. We have an Async Task Manager slide, maybe Allon and I should go over and add more content to it. -- To view, visit http://gerrit.ovirt.org/12561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3839ed09825f1e0db914f55f5ee358b6b3c0449 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
