Liron Ar has posted comments on this change.
Change subject: core: AddDiskCommand.canDoAction() early return
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 87: }
Line 88:
Line 89: if (!acquireLockInternal()) {
Line 90: return false;
Line 91: }
perhaps unite those two if statements
Line 92:
Line 93: VM vm = getVm();
Line 94:
Line 95: if (vm != null) {
Line 93: VM vm = getVm();
Line 94:
Line 95: if (vm != null) {
Line 96: // if user sent drive check that its not in use
Line 97: if (!isDiskCanBeAddedToVm(getParameters().getDiskInfo()) ||
perhaps unite... if (vm != null && ...)
Line 98:
!isDiskPassPciAndIdeLimit(getParameters().getDiskInfo())) {
Line 99: return false;
Line 100: }
Line 101: }
--
To view, visit http://gerrit.ovirt.org/12895
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib89b5008972e6cf895941d211cda5d7f8f14b5e1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
