Liron Ar has posted comments on this change.
Change subject: core: AddDiskCommand.canDoAction() early return
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 265: protected SnapshotDao getSnapshotDao() {
Line 266: return DbFacade.getInstance().getSnapshotDao();
Line 267: }
Line 268:
Line 269: @Override
did you add that intentionally?
Line 270: protected BaseDiskDao getBaseDiskDao() {
Line 271: return DbFacade.getInstance().getBaseDiskDao();
Line 272: }
Line 273:
--
To view, visit http://gerrit.ovirt.org/12895
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib89b5008972e6cf895941d211cda5d7f8f14b5e1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
