Allon Mureinik has uploaded a new change for review. Change subject: core: AuditLogableBaseTest synthetic access ......................................................................
core: AuditLogableBaseTest synthetic access Changed private members to protected to solve synthetic-access warnings. Tis patch contributes to the code cleanliness (less warnings) and may also grant a (very) minor performance boost. Change-Id: I9c238908055e3ee864567233dc145987bced8ba6 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/92/12992/1 diff --git a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java index a760743..14f49eb 100644 --- a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java +++ b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java @@ -33,10 +33,10 @@ public class AuditLogableBaseTest { - private static final Guid GUID = new Guid("11111111-1111-1111-1111-111111111111"); - private static final Guid GUID2 = new Guid("11111111-1111-1111-1111-111111111112"); - private static final Guid GUID3 = new Guid("11111111-1111-1111-1111-111111111113"); - private static final String NAME = "testName"; + protected static final Guid GUID = new Guid("11111111-1111-1111-1111-111111111111"); + protected static final Guid GUID2 = new Guid("11111111-1111-1111-1111-111111111112"); + protected static final Guid GUID3 = new Guid("11111111-1111-1111-1111-111111111113"); + protected static final String NAME = "testName"; @Test public void nGuidCtor() { @@ -1053,7 +1053,7 @@ assertEquals(AuditLogType.UNASSIGNED.toString(), s); } - private class TestAuditLogableBase extends AuditLogableBase { + protected static class TestAuditLogableBase extends AuditLogableBase { public final StorageDomain STORAGE_DOMAIN = new StorageDomain(); @Override -- To view, visit http://gerrit.ovirt.org/12992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9c238908055e3ee864567233dc145987bced8ba6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
