Allon Mureinik has posted comments on this change.
Change subject: core: AuditLogableBaseTest synthetic access
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java
Line 35:
Line 36: protected static final Guid GUID = new
Guid("11111111-1111-1111-1111-111111111111");
Line 37: protected static final Guid GUID2 = new
Guid("11111111-1111-1111-1111-111111111112");
Line 38: protected static final Guid GUID3 = new
Guid("11111111-1111-1111-1111-111111111113");
Line 39: protected static final String NAME = "testName";
yes, exactly.
private fields accessed from inner classes force the JVM to create a synthetic
getter method, which damages performance:
See, e.g., this:
http://stackoverflow.com/questions/921025/eclipse-warning-about-synthetic-accessor-for-private-static-nested-classes-in-ja
Line 40:
Line 41: @Test
Line 42: public void nGuidCtor() {
Line 43: final AuditLogableBase b = new AuditLogableBase(GUID);
--
To view, visit http://gerrit.ovirt.org/12992
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c238908055e3ee864567233dc145987bced8ba6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
