Gilad Chaplik has uploaded a new change for review. Change subject: core: vdsSelector: remove method used once (14/15) ......................................................................
core: vdsSelector: remove method used once (14/15) I want to reduce method count, all methods names sounds the same to me. method removed: isVdsFailedToRunVm Change-Id: I1b872c631a0720c8240136012ea5497326fcf5d0 Signed-off-by: Gilad Chaplik <[email protected]> --- M backend/manager/modules/sla/src/main/java/org/ovirt/engine/core/sla/VdsSelector.java 1 file changed, 1 insertion(+), 16 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/16/13216/1 diff --git a/backend/manager/modules/sla/src/main/java/org/ovirt/engine/core/sla/VdsSelector.java b/backend/manager/modules/sla/src/main/java/org/ovirt/engine/core/sla/VdsSelector.java index 54b2bfc..975638f 100644 --- a/backend/manager/modules/sla/src/main/java/org/ovirt/engine/core/sla/VdsSelector.java +++ b/backend/manager/modules/sla/src/main/java/org/ovirt/engine/core/sla/VdsSelector.java @@ -252,7 +252,7 @@ @Override public VdcBllMessages validate(VDS vds, StringBuilder sb, boolean isMigrate) { - if (isVdsFailedToRunVm(vds.getId())) { + if (getRunVdssList() != null && getRunVdssList().contains(vds.getId())) { sb.append("have failed running this VM in the current selection cycle"); return VdcBllMessages.ACTION_TYPE_FAILED_VDS_VM_CLUSTER; } @@ -274,21 +274,6 @@ } return null; - } - - /** - * Determine if specific vds already failed to run vm - to prevent - * sequential running of vm on problematic vds - * - * @param vdsId - * @return - */ - private boolean isVdsFailedToRunVm(Guid vdsId) { - boolean retValue = false; - if (getRunVdssList() != null && getRunVdssList().contains(vdsId)) { - retValue = true; - } - return retValue; } /** -- To view, visit http://gerrit.ovirt.org/13216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1b872c631a0720c8240136012ea5497326fcf5d0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
