Laszlo Hornyak has posted comments on this change.
Change subject: core: vdsSelector: remove method used once (14/15)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/sla/src/main/java/org/ovirt/engine/core/sla/VdsSelector.java
Line 251: add(new HostValidator() {
Line 252:
Line 253: @Override
Line 254: public VdcBllMessages validate(VDS vds, StringBuilder
sb, boolean isMigrate) {
Line 255: if (getRunVdssList() != null &&
getRunVdssList().contains(vds.getId())) {
That previous thing was more readable for me. This logical expression is quite
hard to follow.
Line 256: sb.append("have failed running this VM in the
current selection cycle");
Line 257: return
VdcBllMessages.ACTION_TYPE_FAILED_VDS_VM_CLUSTER;
Line 258: }
Line 259: return null;
--
To view, visit http://gerrit.ovirt.org/13216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b872c631a0720c8240136012ea5497326fcf5d0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
