Yair Zaslavsky has posted comments on this change. Change subject: engine: Compare and set instead of updateVdsDynamic in VM scenarios ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) .................................................... File backend/manager/dbscripts/vds_sp.sql Line 919: AS $procedure$ Line 920: DECLARE Line 921: sign int; Line 922: BEGIN Line 923: IF (v_memCommited = 0 ) THEN Please remove tabs Line 924: sign = 0; Line 925: ELSEIF (v_memCommited > 0) THEN Line 926: sign = 1; Line 927: ELSE -- To view, visit http://gerrit.ovirt.org/13682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363afc5c3411b0c13e6d6c9ed5b16004738b6ca7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
