Michael Kublin has posted comments on this change.
Change subject: engine: Compare and set instead of updateVdsDynamic in VM
scenarios
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java
Line 61: }
Line 62: }
Line 63:
Line 64: private void updateDestinationVds(final Guid dstVdsId, final VM
vm) {
Line 65: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
I will return a thread , a change should be checked more and also not related
directly to that patch
Line 66: @Override
Line 67: public Void runInTransaction() {
Line 68: DbFacade.getInstance()
Line 69: .getVdsDynamicDao()
--
To view, visit http://gerrit.ovirt.org/13682
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363afc5c3411b0c13e6d6c9ed5b16004738b6ca7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
