Alon Bar-Lev has posted comments on this change. Change subject: packaging: update httpd conf on engine-upgrade ......................................................................
Patch Set 2: (1 inline comment) > Patch updated, requires http://gerrit.ovirt.org/13751 to be merged first. You should rebase on top of that patch and submit, then dependencies will not allow gerrit to merge this one without its dependency. .................................................... File packaging/fedora/setup/engine-upgrade.py Line 1085: ) Line 1086: Line 1087: if ( Line 1088: os.path.exists(basedefs.FILE_OVIRT_HTTPD_CONF_ROOT) or Line 1089: utils.askYesNo('\nDo you want to enable root redirection') I think the upgrade should not ask anything by convention... if the FILE_OVIRT_HTTPD_CONF exists and this is upgrade from 3.2 we can safely copy the root redirection.... Line 1090: ): Line 1091: utils.copyFile( Line 1092: basedefs.FILE_OVIRT_HTTPD_CONF_ROOT_TEMPLATE, Line 1093: basedefs.FILE_OVIRT_HTTPD_CONF_ROOT, -- To view, visit http://gerrit.ovirt.org/13741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73175ef2acc9cf88261eb7df4f17602085151b1c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
