Alon Bar-Lev has posted comments on this change.
Change subject: packaging: update httpd conf on engine-upgrade
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 1094: basedefs.FILE_OVIRT_HTTPD_CONF_ROOT_TEMPLATE,
Line 1095: basedefs.FILE_OVIRT_HTTPD_CONF_ROOT,
Line 1096: )
Line 1097:
Line 1098:
I don't fully understand...
I think something like, can you please tell me what is missing?
if os.path.exists(basedefs.FILE_OVIRT_HTTPD_CONF_LEGACY):
os.rename(
basedefs.FILE_OVIRT_HTTPD_CONF_LEGACY,
"%s.%s" %(
basedefs.FILE_OVIRT_HTTPD_CONF_LEGACY,
@DATE@,
),
)
utils.processTemplate(
basedefs.FILE_OVIRT_HTTPD_CONF_TEMPLATE,
basedefs.FILE_OVIRT_HTTPD_CONF,
)
utils.processTemplate(
basedefs.FILE_OVIRT_HTTPD_CONF_ROOT_TEMPLATE,
basedefs.FILE_OVIRT_HTTPD_CONF_ROOT,
)
Line 1099: def main(options):
Line 1100: # BEGIN: PROCESS-INITIALIZATION
Line 1101: miniyumsink = utils.MiniYumSink()
Line 1102: MiniYum.setup_log_hook(sink=miniyumsink)
--
To view, visit http://gerrit.ovirt.org/13741
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73175ef2acc9cf88261eb7df4f17602085151b1c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
