Shireesh Anjal has posted comments on this change.
Change subject: engine: Disable gluster hook command
......................................................................
Patch Set 7: (3 inline comments)
- Few minor comments
- I think an entry needs to be added to AppErrors.properties for
VAR__ACTION__DISABLE
- Please rebase
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DisableGlusterHookCommand.java
Line 22: }
Line 23:
Line 24: @Override
Line 25: protected void setActionMessageParameters() {
Line 26:
addCanDoActionMessage(VdcBllMessages.VAR__ACTION__DISABLE_GLUSTER_HOOK);
Please change this to VAR__ACTION__DISABLE
Line 27: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__GLUSTER_HOOK);
Line 28: }
Line 29:
Line 30:
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DisableGlusterHookCommandTest.java
Line 40: public void canDoActionFailsOnNullHookId() {
Line 41: cmd = spy(new DisableGlusterHookCommand(new
GlusterHookParameters(CLUSTER_ID, null)));
Line 42: setupMocks(cmd);
Line 43: assertFalse(cmd.canDoAction());
Line 44: }
Can you add canDoActionFailsOnInvalidHookId() ?
Line 45:
Line 46: @Test
Line 47: public void executeCommand() {
Line 48: cmd = spy(new DisableGlusterHookCommand(new
GlusterHookParameters(CLUSTER_ID, HOOK_ID)));
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java
Line 36:
Guid.createGuidFromString("2001751e-549b-4e7a-aff6-32d36856c125")};
Line 37: protected static final Guid CLUSTER_ID = new
Guid("b399944a-81ab-4ec5-8266-e19ba7c3c9d1");
Line 38: protected static final Guid HOOK_ID =
Guid.createGuidFromString("d2cb2f73-fab3-4a42-93f0-d5e4c069a43e");
Line 39: @Rule
Line 40: public MockConfigRule mcr = new MockConfigRule();
configs to be mocked can be passed to constructor itself instead of having a
separate method mockConfig()
Line 41: @Mock
Line 42: private GlusterHooksDao hooksDao;
Line 43: @Mock
Line 44: private VdsGroupDAO vdsGroupDao;
--
To view, visit http://gerrit.ovirt.org/11073
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb3e034013d2ceb3590a61efc9bc46b1c3f378f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
