Shireesh Anjal has posted comments on this change.
Change subject: engine: Disable gluster hook command
......................................................................
Patch Set 8: Looks good to me, approved
(1 inline comment)
One last minor comment in-line :)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DisableGlusterHookCommandTest.java
Line 43: assertFalse(cmd.canDoAction());
Line 44: }
Line 45:
Line 46: @Test
Line 47: public void canDoActionFailsOnNullHook() {
In all the canDoActionFails* tests, you can also verify the exact error
message, similar to what is done in EnableGlusterHookCommandTest
assertTrue(cmd.getReturnValue().getCanDoActionMessages().contains(VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_HOOK_DOES_NOT_EXIST.toString()));
Line 48: cmd = spy(new DisableGlusterHookCommand(new
GlusterHookParameters(CLUSTER_ID, HOOK_ID)));
Line 49: setupMocks(cmd,false);
Line 50: assertFalse(cmd.canDoAction());
Line 51: }
--
To view, visit http://gerrit.ovirt.org/11073
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb3e034013d2ceb3590a61efc9bc46b1c3f378f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
